This repository was archived by the owner on Apr 21, 2022. It is now read-only.
Try to flush after failing without waiting for the next log.#93
Merged
vilyapilya merged 6 commits intomasterfrom Feb 19, 2020
Merged
Try to flush after failing without waiting for the next log.#93vilyapilya merged 6 commits intomasterfrom
vilyapilya merged 6 commits intomasterfrom
Conversation
vilyapilya
changed the title
smusali
approved these changes
Feb 19, 2020
Contributor
smusali
left a comment
smusali
left a comment
There was a problem hiding this comment.
implementation-wise, it looks good to me - but before publishing, CircleCI will create GitHub Release with the zipped package to be tested and confirmed it's all good to go to be published.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously: when the logger fails to send a log, it saved the message in the buffer and attempts to send it only after receiving the next log.
Now: when the logger fails to send a log, it tries to send it three times (after backoff period is passed) without waiting for the next log to come. If it fails to send it three (configurable) times, it saves it in the buffer and attempts again when the next message comes.